Skip to content

feat: Quilt client part ii #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jun 14, 2025
Merged

feat: Quilt client part ii #2171

merged 44 commits into from
Jun 14, 2025

Conversation

liquid-helium
Copy link
Contributor

@liquid-helium liquid-helium commented Jun 3, 2025 •
edited
Loading

Description

Added QuiltClient to handle storing/reading quilts.
Contributes to WAL-858

Test plan

How did you test the new or updated feature?

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)

  • Storage node:
  • Aggregator:
  • Publisher:
  • CLI:

@liquid-helium
minor refactor.
38f6107
@liquid-helium
cleanup.
146284e
@liquid-helium
cleanup.
7830f6c
@liquid-helium
cleanup.
a64b2a0
@liquid-helium
collect_to_vec
1010fce
@liquid-helium
swithced to QuiltColumnRangeReader.
6fef765
@liquid-helium
applied comment changes.
5df2bb4
@liquid-helium
improved add_blob_to_quilt.
bdde701
@liquid-helium
removed MergeIterator.
1bfa1aa
@liquid-helium
updated the doc strings.
5915a63
@liquid-helium
cleanup.
bbfc7a0
@liquid-helium
cleanup.
6a1a4e4
@liquid-helium
cleanup.
806d13e
@liquid-helium
simplify.
23cbc90
@liquid-helium
cleanup
dc5440b
@liquid-helium
Merge branch 'main' of https://github.com/MystenLabs/walrus into quil…
2e4bee3 
…t-encoding-part-ii
@liquid-helium
1st
aec5dbe
@liquid-helium
check
06e0a6d
@liquid-helium
cleanup
eda9182
@liquid-helium
Added QuiltIndexApi
74b778c
@liquid-helium
Renamed QuiltBlobId to QuiltPatchId.
aa62a57
@liquid-helium
Allow a max of 10 slivers for the index, added tests for it.
eb7f98d
@liquid-helium
Merge branch 'main' of https://github.com/MystenLabs/walrus into quil…
a613ab0 
…t-client-i
@liquid-helium
rename function.
61153ea
@liquid-helium
Merge with quilt-client-part-i
4084c7a
@liquid-helium
Added stored quilt patch.
a90e14b
@liquid-helium
added quilt_client
071bae7
@liquid-helium
updated read file functions, added tests.
08a97e1
@liquid-helium
cleanup
add0520
@liquid-helium
added test.
a726495
@liquid-helium liquid-helium changed the base branch from main to quilt-client-i June 3, 2025 22:47
Base automatically changed from quilt-client-i to main June 11, 2025 19:30
@liquid-helium liquid-helium marked this pull request as ready for review June 12, 2025 03:12
@liquid-helium liquid-helium requested a review from mlegner June 12, 2025 03:12
mlegner
mlegner reviewed Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, @liquid-helium, really nice! As usual, a few mostly minor comments and suggestions.

@github-actions GitHub Actions
Copy link
Contributor

Warning: This PR modifies the Walrus CLI. Please consider the following:

  • Make sure the changes are backwards compatible. Consider deprecating options before
    removing them.
  • Generally only use long CLI options, not short ones to avoid conflicts in the
    future.
  • If you added new options or features, or modified the behavior, please document the
    changes in the release notes of the PR and update the documentation in the docs/book
    directory.

@liquid-helium
Copy link
Contributor Author

liquid-helium commented Jun 12, 2025 •
edited
Loading

Thanks a lot for the PR, @liquid-helium, really nice! As usual, a few mostly minor comments and suggestions.

Thanks @mlegner for the suggestions and comments, these are really helpful! PTAL.

@liquid-helium liquid-helium requested a review from mlegner June 13, 2025 04:45
mlegner
mlegner approved these changes Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @liquid-helium, LGTM! 💯

@liquid-helium liquid-helium merged commit 101ff37 into main Jun 14, 2025
25 checks passed
@liquid-helium liquid-helium deleted the quilt-client-part-ii branch June 14, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liquid-helium @mlegner